Turn let-else statements into let and match #12130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
☔ The latest upstream changes (presumably #12118) made this pull request unmergeable. Please resolve the merge conflicts. |
weirane
force-pushed
the
let-else-let-match
branch
from
60fed92 to
59cdb31
Compare
Veykril
reviewed
May 2, 2022
weirane
force-pushed
the
let-else-let-match
branch
from
f875d05 to
a70beea
Compare
Veykril
reviewed
May 5, 2022
weirane
force-pushed
the
let-else-let-match
branch
from
4059fa1 to
8d7a393
Compare
Veykril
reviewed
May 17, 2022
Member
|
@bors delegate+ |
Contributor
|
✌️ @weirane can now approve this pull request |
Co-authored-by: Lukas Wirth <[email protected]>
weirane
force-pushed
the
let-else-let-match
branch
from
0d3d520 to
4a0821f
Compare
Contributor
Author
|
@bors r+ |
Contributor
|
📌 Commit 4a0821f has been approved by |
Contributor
Contributor
Author
|
Thanks for the suggestions! |
Contributor
|
☀️ Test successful - checks-actions |
Member
let-else.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11906.