-
Notifications
You must be signed in to change notification settings - Fork 1.2k
libc: fix reg32 on 32 bit freebsd #4674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ba05c1
to
27fc39f
Compare
There's only one What's happening is that libc is being expanded as if it was 64 bit, causing this problem. I'm not sure but we might be able to fix this if we pass in the correct target when expanding macros? |
It worked! (FreeBSD 13 still likes to segfault, we might have to rerun multiple times, but it does work now) |
dce6e3c
to
f5b4cfd
Compare
This also fixes missing `reg32` struct bugs on 32-bit FreeBSD.
Description
Attempts to fix errors in freebsd i686 by making sure that the correct build target is used when expanding macros.
Sources
https://cgit.freebsd.org/src/tree/sys/x86/include/reg.h?h=releng/13.1
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI