libc: use more accurate type of sighandler_t on windows #4602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
reviewed
Aug 9, 2025
| @@ -10,7 +10,7 @@ pub type ptrdiff_t = isize; | |||
| pub type intptr_t = isize; | |||
| pub type uintptr_t = usize; | |||
| pub type ssize_t = isize; | |||
| pub type sighandler_t = usize; | |||
| pub type sighandler_t = *const c_void; | |||
There was a problem hiding this comment.
One concern: if Rust ever does get raw function pointers, it would be a breaking change to start using them. So I'm thinking maybe we should create an opaque type that would let us change to a raw function pointer at some point, ideally something compatible with rust-lang/libs-team#589 (comment).
Will need to think about this a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the type of
sighandler_ton windows fromusizeto*const c_voidas per #1637 to more accurately represent the fact that it is a pointer to a function (since the value of the address is also sometimes matched without dereferencing it).A better type would be
Option<extern fn ...>however because of the dual use ofsighandler_tas a constant, it would be undefined behavior to construct that type from something like5.Sources
https://github.com/msys2/msys2-runtime/blob/23a25d49e3b8c18f12ce588869d4cb24de9f2454/newlib/libc/machine/cris/sys/signal.h#L23
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI