Skip to content

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Aug 22, 2025

Closes #132

@bjorn3
Copy link
Member Author

bjorn3 commented Aug 22, 2025

Can we bump the MSRV to 1.68? That is the first version stabilizing the sparse registry. Due to the lack of sparse registry support the MSRV job currently takes several minutes while all other jobs finish in half a minute.

@the8472
Copy link
Member

the8472 commented Aug 22, 2025

I haven't found anything explicitly saying what semver policy around default features is, but this could be a breaking change for default-features=false dependents... but currently there only is rustc-dep-of-std which hopefully nobody but std is using, so it's probably fine.

@bjorn3
Copy link
Member Author

bjorn3 commented Aug 22, 2025

The worst thing that can happen when disabling this feature unintentionally is that the help text is twice as wide as it should be causing wrapping inside a terminal.

@bjorn3
Copy link
Member Author

bjorn3 commented Aug 29, 2025

Is there anything that needs to be done for this to be merged?

@the8472
Copy link
Member

the8472 commented Aug 29, 2025

Ah sorry, I assumed you had permission.

@the8472 the8472 merged commit 03ce599 into rust-lang:master Aug 29, 2025
9 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2025
@bjorn3 bjorn3 deleted the optional_unicode_width branch August 29, 2025 11:20
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 29, 2025

I technically do have write permission, but I figured I shouldn't use it given that I never touched this crate before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does getopts actually need to depend on unicode-width?
2 participants