fix huge diff in consistency check due to different sorting #3014
+44
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Nov 21, 2025
syphar
force-pushed
the
fix-consistency-check
branch
from
25dab0e to
325738f
Compare
github-actions
bot
added
S-waiting-on-deploy
syphar
added
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression from #2969.
When trying to run the consistency check, it wanted to drop & requeue the same releases, ~500k times.
Digging into it, it was a classical sorting error :D
Previously: text. Which means the order is:
0.10.3,0.6.0,0.9.3. Since we sorted both sides (index & db) the same way, the diff worked.Now, with semver, the order changes:
0.6.0,0.9.3,0.10.3. So in the place where we manually ordered in rust code (index reading), the order changed. In the place where we used database sorting, the order didn't change.For now I just re-sort the database entries in rust code, and added a test.