Add trustpub_only flag
#12365
Open
Add trustpub_only flag
#12365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-enhancement ✨
Turbo87
force-pushed
the
trustpub-only
branch
from
8315034 to
4c4deb5
Compare
Turbo87
force-pushed
the
trustpub-only
branch
from
4c4deb5 to
1b5fb23
Compare
LawnGnome
approved these changes
Nov 20, 2025
Contributor
LawnGnome
left a comment
LawnGnome
left a comment
There was a problem hiding this comment.
LGTM. One or two comments, but the implementation looks good!
| && matches!(auth, AuthType::Regular(_)) | ||
| { | ||
| return Err(forbidden( | ||
| "You tried to publish with an API token but this crate requires trusted publishing.", |
Contributor
There was a problem hiding this comment.
I think people may be confused by "API token" as a term of art, so how about:
Suggested change
| "You tried to publish with an API token but this crate requires trusted publishing.", | |
| "New versions of this crate can only be published using Trusted Publishing.", |
| {%- endif %} | ||
|
|
||
| {% if trustpub_only -%} | ||
| This crate can now ONLY be published via Trusted Publishing. Publishing with API tokens has been disabled. |
Contributor
There was a problem hiding this comment.
(to follow on from my previous comment, I don't have the same concern over the use of "API token" here because the user is likely to have immediate context, since they or another owner were just thinking about trusted publishing)
| let response = user.patch::<()>(url, body.to_string()).await; | ||
| assert_snapshot!(response.status(), @"200 OK"); | ||
| assert_json_snapshot!(response.json(), { | ||
| ".crate.created_at" => "[datetime]", |
Contributor
There was a problem hiding this comment.
Should we also explicitly be checking .crate.trustpub_only at this point? (Here and below.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the backend part of #12361.
It adds a new
trustpub_onlycolumn to thecratestable, exposes the field in the API responses, adjusts the publish endpoint to check it, and implements a newPATCH /api/v1/crates/{name}endpoint to toggle it.The UI implementation will follow in a dedicated PR.