Add optional defmt support for error types #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add defmt as an optional dependent package
ryan-summers
reviewed
Nov 4, 2023
Member
|
I think there's one last formatting issue, and one compile issue (don't need a defmt:: prefix). Try it locally with |
Contributor
Author
|
All done! |
Co-authored-by: Diego Barrios Romero <[email protected]>
eldruin
reviewed
Nov 7, 2023
Member
eldruin
left a comment
eldruin
left a comment
There was a problem hiding this comment.
Uh, could you update the MSRV to 1.60 as well?
Contributor
Author
|
Sure, done! |
Member
|
I think the msrv workflow is still referring to 1.56, sorry for all the tiny details here. |
Member
|
Hmm 1.60 seems not enough. Could you bump it to 1.62.0? |
ryan-summers
approved these changes
Nov 8, 2023
Member
ryan-summers
left a comment
ryan-summers
left a comment
There was a problem hiding this comment.
Thanks for working through this, everything's looking good now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add defmt as an optional dependent package
closes #75
closes #76