Introduce an example binary useful for profiling #646
Conversation
|
Cool idea, should we be doing this for our other crates (specifically as we crate smash them out of |
|
We may want a |
|
Certainly it is useful in other crates too, but at the moment in particular this crate and its companion elements-miniscript have high percentage of binary size consumption in downstream libraries due to the high use of generics so it makes the most sense here. |
Why do you think this is not meant to be in this repo? Thanks to the |
|
Sorry, I didn't actually look at the diff (because I am waiting for #645 to get in so that CI will work). I didn't realize it was actually an example in the Yes, this should certainly stay in this repo. My comments about wanting a maintainer-tools repo are separate -- we should have this anyway so we can deduplicate our test scripts and write "end to end" tests of the whole ecosystem. |
|
Rebased and added some calls: in debug big executable is 72Mb and the second biggest example is 51Mb (41% bigger) |
examples/big.rs
Outdated
| @@ -0,0 +1,40 @@ | |||
| // SPDX-License-Identifier: CC0-1.0 | |||
| //! This is not an example and will surely panic if executed, the purpose of this is using the | |||
There was a problem hiding this comment.
Ah, the formatter got this in the last commit.
|
Let's get this in. It's a super useful benchmark. I am planning to give "redo the error types" a shot in the coming week and hopefully I can get this size down. |
…seful for profiling c8d3b9ac1f9ec913eb30768439f0f5f4db9a02be fix formatting in big example (Riccardo Casatta) bc47538c2b0e126fbea20de9c27f4a6aea61d711 add taproot calls in big executable (Riccardo Casatta) 545bbbebe97bbad0080ad58b6ab2d6403ac0211b add satisfy call in big executable (Riccardo Casatta) 959546b5ec6c12a40f6838f48e6ca67690638e21 add psbt finalize call in big executable (Riccardo Casatta) 883132ed7a1d26fd0650dda7732d8dd1e250baad add policy calls in big executable (Riccardo Casatta) ec751fb06b7af82f20936208c377c61960f53648 Introduce an example binary useful for profiling (Riccardo Casatta) Pull request description: Tools like `cargo bloat` don't work on libraries but on final executable. As seen in rust-bitcoin/rust-miniscript#585 and rust-bitcoin/rust-miniscript#584 the parse example is used as a base to profile binary bloat. However, since the parse example is not using all the API surface, we may have good optimization that are not recognized as such because the optimized function are not in the tree of the functions used. For benchmarking size optimization a specific binary that ideally touch all the API surface is needed and this MR introduce it. More coverage will be added if this seem a good idea for reviewers. ACKs for top commit: apoelstra: ACK c8d3b9ac1f9ec913eb30768439f0f5f4db9a02be thanks! Tree-SHA512: 70ac51a222b59b5de76a2ef314be2f3d82b3f5831d90dd7110929a4956a27a6d1eaa4889525dbf54575fb7e07db60f19d67556f2539b61979b4ba681fec0523e
3 participants
Tools like
cargo bloatdon't work on libraries but on final executable.As seen in #585 and #584 the parse example is used as a base to profile binary bloat.
However, since the parse example is not using all the API surface, we may have good optimization that are not recognized as such because the optimized function are not in the tree of the functions used.
For benchmarking size optimization a specific binary that ideally touch all the API surface is needed and this MR introduce it.
More coverage will be added if this seem a good idea for reviewers.