Update MSRV to 1.48. Fixes CI #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanket1729
force-pushed
the
msrv
branch
2 times, most recently
from
5f15aa9 to
1a62635
Compare
sanket1729
force-pushed
the
msrv
branch
2 times, most recently
from
f953605 to
1baa550
Compare
Member
|
Can you update the fuzzer rustc to 1.64 from 1.58, and also update |
Member
Author
|
Nice. Found a new fuzz failure |
tcharding
reviewed
Jul 18, 2023
Member
tcharding
left a comment
tcharding
left a comment
There was a problem hiding this comment.
LGTM, glad to see you worked out the pinning, I tried and failed yesterday. (FWIW I used LGTM instead of ACK because I'm assuming you are going to squash the fix! commits.)
sanket1729
force-pushed
the
msrv
branch
3 times, most recently
from
d33562d to
13950fd
Compare
Member
Author
|
After a lot of iteration on fuzzer, this is finally ready for review. |
apoelstra
reviewed
Jul 19, 2023
.gitconfig
Outdated
| @@ -0,0 +1,3 @@ | |||
| [remote "upstream"] | |||
| fetch = +refs/pull/*:refs/remotes/pr/* | |||
| fetch = +refs/merge-requests/*:refs/remotes/pr/* No newline at end of file | |||
Member
There was a problem hiding this comment.
it's deleted in the next commit, but could still cause weird things to happen during bisection.
apoelstra
reviewed
Jul 19, 2023
| /// Helper function to compile different types of binary fragments. | ||
| /// `sat_prob` and `dissat_prob` represent the sat and dissat probabilities of | ||
| /// root or. `weights` represent the odds for taking each sub branch | ||
| #[allow(clippy::too_many_arguments)] |
Member
There was a problem hiding this comment.
In e491308:
I think this is fine, but FYI both this and the "too many arguments" lint thresholds can be set globally in clippy.toml.
apoelstra
reviewed
Jul 19, 2023
src/expression.rs
Outdated
| if !ch.is_ascii() { | ||
| return Err(Error::Unprintable(ch)); | ||
| } | ||
| // TODO: Avoid linear search overhead by using OnceCell to cache this in a BTreeMap. |
Member
There was a problem hiding this comment.
In 13950fd:
Since all our allowed characters are 127 or less, we could just make a static 128-entry array of bool rather than a BTreeMap. But the linear search is fine for now.
apoelstra
previously approved these changes
Jul 19, 2023
Member
|
Oh, actually, I'd like you to remove the spurious file before merging. |
Caught by fuzz tests. We directly assumed that the internal key is a
valid string if it was between '(' and ')' and did not contain any ','
This results in fuzzer crash when trying compute the checksum in `Display` implemenation of Descriptor
Also improves the efficiency of descriptor checksum code.
Member
Author
|
Added another commit that adds a static vector for character lookups |
apoelstra
approved these changes
Jul 19, 2023
apoelstra
approved these changes
Jul 19, 2023
Merged
apoelstra
added a commit
to apoelstra/rust-miniscript
that referenced
this pull request
Jul 4, 2025
This results in fuzzer crash when trying compute the checksum in `Display` implemenation of Descriptor Backport of 60fde9e from rust-bitcoin#569.
apoelstra
added a commit
to apoelstra/rust-miniscript
that referenced
this pull request
Jul 5, 2025
This results in fuzzer crash when trying compute the checksum in `Display` implemenation of Descriptor Backport of 60fde9e from rust-bitcoin#569.
apoelstra
added a commit
to apoelstra/rust-miniscript
that referenced
this pull request
Jul 5, 2025
This results in fuzzer crash when trying compute the checksum in `Display` implemenation of Descriptor Backport of 60fde9e from rust-bitcoin#569.
apoelstra
added a commit
to apoelstra/rust-miniscript
that referenced
this pull request
Jul 5, 2025
This results in fuzzer crash when trying compute the checksum in `Display` implemenation of Descriptor Backport of 60fde9e from rust-bitcoin#569.
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
6b76997b14fd606b6ceba884012512c06200a4a4 Use a static map to lookup which characters are allowed (sanket1729)
60fde9e9519125d3b1ecccea302a0a6e6ce484fa Check that we only accept INPUT_CHARSET in from_str (sanket1729)
a3966059fa38e64800f86306fb9312e67ba7f1dc Fix taproot internal key parsing (sanket1729)
68c7c49d9a5c53de346cd1c562bd0a1250c112a4 clippy warnings (sanket1729)
b238366492a320ce58a01b5549cd2459abd9465f Update MSRV to 1.48 (sanket1729)
Pull request description:
ACKs for top commit:
apoelstra:
ACK 6b76997b14fd606b6ceba884012512c06200a4a4
Tree-SHA512: 5b42b3a1d8156c5a7aa5924bfbc5d79f8196173b4f9a2b502480edbfa4d2f9e2cd74dd34839de76e12a74ad0ccfc335f816890db1b4b6705bdbb2e7bc81fcebc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.