29 split withdraw excess and set_authority proofs, update proof table #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
commented
Oct 7, 2025
p-token/test-properties/tests.md
Outdated
There was a problem hiding this comment.
Happy to modify the PR and replace this file by a simple list of test names. Keeping all results up to date seems not very practical anyway.
There was a problem hiding this comment.
I like the sound of that
dkcumming
changed the title
dkcumming
reviewed
Oct 7, 2025
Comment on lines
3685
to
3688
| let mut multisig_is_initialised: Result<bool, ProgramError> = Err(ProgramError::Custom(999)); | ||
| if accounts[2].data_len() == Multisig::LEN { | ||
| multisig_is_initialised = get_multisig(&accounts[2]).is_initialized(); | ||
| } |
There was a problem hiding this comment.
@jberthold what do you think of this? I wanted the concrete tests to run the multisig signers case and this got it to run successfully. I think this might be preferable to the feature flag.
…rification/solana-token into 29-split-withdraw-excess-proof
tothtamas28
approved these changes
Oct 7, 2025
This was referenced Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update proof status table (already done in github issue)
tests.mdto to a list of proofs to runSplit
withdraw_excess_lamportsproof into cases forAccountandMint(and prepareMultisig)Mint-related code inwithdraw_excess_lamportsproof for initial test (fails due to Cheat code forSysvar::<Rent>::get#37 )Mintcase, adapt pre- and post-conditionsMultisigcase, adapt pre- and post-conditionsmultisig_is_initialisedwith sentinel error value, this removes conditional compilation and allows concrete tests to pass. - Need feedback on this approachSplit
set_authorityproof into cases forAccountandMintBug fix concrete tests:
Burn{Checked}assumed owner ofAccountInfowould be the owner ofAccountSee INVESTIGATION:AccountInfo.owner != Account.owner#38CloseAccounttest for when accounts were the same was buggy