Crash: HTTP HEAD requests MUST NOT include a request body

[felixfbecker]

Apr 3 22:45:50 npm-proxy err /usr/local/lib/node_modules/npm-proxy-cache/node_modules/request/index.js:51
Apr 3 22:45:50 npm-proxy err     throw new Error('HTTP HEAD requests MUST NOT include a request body.')
Apr 3 22:45:50 npm-proxy err     ^
Apr 3 22:45:50 npm-proxy err 
Apr 3 22:45:50 npm-proxy err Error: HTTP HEAD requests MUST NOT include a request body.
Apr 3 22:45:50 npm-proxy err     at request (/usr/local/lib/node_modules/npm-proxy-cache/node_modules/request/index.js:51:11)
Apr 3 22:45:50 npm-proxy err     at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/npm-proxy-cache/lib/proxy.js:231:12)
Apr 3 22:45:50 npm-proxy err     at emitNone (events.js:86:13)
Apr 3 22:45:50 npm-proxy err     at IncomingMessage.emit (events.js:188:7)
Apr 3 22:45:50 npm-proxy err     at endReadableNT (_stream_readable.js:975:12)
Apr 3 22:45:50 npm-proxy err     at _combinedTickCallback (internal/process/next_tick.js:80:11)
Apr 3 22:45:50 npm-proxy err     at process._tickCallback (internal/process/next_tick.js:104:9)

[runk]

Not very informative. What how when?

Anyway I've upgraded request dep. #51

[felixfbecker]

I am using the npm proxy with yarn and am seeing this error constantly in the logs, causing a container restart. Any other information I can provide?

[runk]

Please try latest version.

Can you narrow down the problem? Is it specific module or specific yarn task?

[felixfbecker]

I will update later, I don't think that would fix it though, because the request update was only a minor update, so it was probably already included.

The logs don't yield any useful information unfortunately, but given the frequency this happens (it is basically crash-looping) I don't think it's hard to reproduce.

I don't know if this is yarn sending invalid requests, or one is simply not allowed to pass any body parameter at all to request when doing a HEAD and only yarn does HEAD requests, npm not. I assume the easy fix would be to only set params.body if req.method !== 'HEAD': https://sourcegraph.com/github.com/runk/npm-proxy-cache@05b07d19bf6e8eb6c73057b085b3c3558861d0f6/-/blob/lib/proxy.js#L237:1-238:1

Besides that, an error like that shouldn't crash the process, so there should be an error handler attached to the stream with .on('error', ...): https://sourcegraph.com/github.com/runk/npm-proxy-cache@05b07d19bf6e8eb6c73057b085b3c3558861d0f6/-/blob/lib/proxy.js#L254:1-255:1

[runk]

Hmmm. It'd be nice to see what's in that body, maybe it's an empty buffer..? Can you try to modify local version of module to debug it?

[felixfbecker]

I debugged it, the buffer is empty.

[felixfbecker]

Also found a repro case, clone https://github.com/Microsoft/vscode and run yarn --ignore-scripts

[runk]

Thanks for the fix, I've published v0.8.1 - give it a go

[felixfbecker]

Thanks for the merge! I think you forgot to push the commit to GitHub though

[runk]

Good call. Should be all there, including tags.

…

On 5 April 2017 at 09:09, Felix Becker ***@***.***> wrote: Thanks for the merge! I think you forgot to push the commit to GitHub though — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#50 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA3KB83dTVOlsRapKx9M5JL1HhYWKxNnks5rss2egaJpZM4MyE1p> .

-- Cheers, Dmitry