Skip to content

Conversation

@daradib
Copy link
Contributor

@daradib daradib commented Oct 8, 2025

Description

Replaces Pool.starmap with Pool.imap to enable progress bar for loading data with multiple workers. Also reduces code duplication across single and multi-worker paths and adds an optional total parameter to get_tqdm_iterable.

Fixes #20047

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

Allows callers to specify the total number of items when the iterable's
length cannot be automatically determined by tqdm.
Replace starmap with imap for multiprocessing to enable progress
tracking. Extract common load_file arguments into a partial function to
reduce code duplication across single and multi-worker paths.
@daradib daradib marked this pull request as ready for review October 8, 2025 04:45
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 8, 2025
Copy link
Member

@AstraBert AstraBert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 10, 2025
@logan-markewich logan-markewich merged commit f8da51d into run-llama:main Oct 12, 2025
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: No progress bar when loading with multiple workers

3 participants