Skip to content

Conversation

@Nightwing-77
Copy link
Contributor

Description

This PR fixes typos and incorrect references in the Sarvam AI integration in llama_index.

  • Renames class from Servam to Sarvam
  • Updates default model from "servam-m" to "sarvam-m"
  • Updates API base from servam.ai to sarvam.ai
  • Updates environment variable from SERVAM_API_KEY to SARVAM_API_KEY
  • Fixes docstrings and package installation instructions

Fixes #19931

New Package?

  • Yes
  • No

Version Bump?

  • Yes
  • No

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • I added/updated relevant unit tests (if applicable)
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 24, 2025
Copy link
Member

@AstraBert AstraBert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you need to change the details in the pyproject.toml of the integration to make this change effective tho (otherwise it will be still published under the old name)

@Nightwing-77
Copy link
Contributor Author

Looks good, you need to change the details in the pyproject.toml of the integration to make this change effective tho (otherwise it will be still published under the old name)

Done, thanks!

@AstraBert AstraBert enabled auto-merge (squash) September 25, 2025 13:54
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2025
@AstraBert
Copy link
Member

Hey @Nightwing-77 there is a problem with the pyproject.toml, it seems to be invalid... When it is fixed, we can merge this :))

auto-merge was automatically disabled September 25, 2025 16:53

Head branch was pushed to by a user without write access

@Nightwing-77
Copy link
Contributor Author

Hey @Nightwing-77 there is a problem with the pyproject.toml, it seems to be invalid... When it is fixed, we can merge this :))

i missed a comma 😭, my bad

@AstraBert AstraBert enabled auto-merge (squash) September 25, 2025 17:04
@AstraBert AstraBert merged commit ffcfb27 into run-llama:main Sep 25, 2025
11 checks passed
@Nightwing-77 Nightwing-77 deleted the sarvam branch September 29, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: issues and typos in Sarvam integration

2 participants