Skip to content

Conversation

@Florian-BACHO
Copy link
Contributor

Description

Following PR #19853, I noticed that I forgot to add FileAPI support for the DocumentBlock type.
This PR adds this support.

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 18, 2025
Copy link
Member

@AstraBert AstraBert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, just some logic I am not so sure I fully understand (see comment below), but once that is set this is good to go!

@AstraBert AstraBert enabled auto-merge (squash) September 22, 2025 10:04
@AstraBert AstraBert disabled auto-merge September 22, 2025 10:04
@AstraBert AstraBert merged commit fe4cb0b into run-llama:main Sep 22, 2025
10 of 11 checks passed
frankiekim5 pushed a commit to frankiekim5/bedrock-agentcore-memory that referenced this pull request Sep 24, 2025
* Add missing FileAPI support for documents

* Bump version to 5.0.1

---------

Co-authored-by: Florian-BACHO <[email protected]>
@Florian-BACHO Florian-BACHO deleted the add_document_fileapi_support branch October 27, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants