-
Notifications
You must be signed in to change notification settings - Fork 6.5k
INTPYTHON-701 - Use PyMongo Asynchronous API instead of Motor #19875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Passing tests in our testing pipeline repo: mongodb-labs/ai-ml-pipeline-testing#101. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hi @logan-markewich. This is a small upgrade as our core python driver, pymongo, now contains an asynchronous client. We are deprecating motor. Would you please review? |
|
Thanks @logan-markewich! |
Description
Motor is officially deprecated in favor of the asynchronous API added to PyMongo in 4.13: https://github.com/mongodb/motor. This PR replaces Motor with that API in all LlamaIndex MongoDB integrations and updates dependencies accordingly.
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods