-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Fix/llama index vector stores azureaisearch fix #19800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/llama index vector stores azureaisearch fix #19800
Conversation
|
While you're at it, mind making another minor change ? The def aquery ( line 1270) Can we update it to : To make it consistent with def query ? |
|
|
||
| search_params.pop("odata_filter", None) | ||
| search_params.pop("odata_filters", None) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @federicocaccialanzaabb
Instead of popping these kwargs in multiple create_query_result function
I feel it's worth maybe popping them in here line : 1219
def query function, once we have loaded the odata_filter kwargs and then pop those 2 fields from the Kwargs that's initializing the downstream Azure classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ciao @Jash271,
you are right it was a little bit a lazy commit,
I improved the code and run the tests,
check the aquery function too, I found what could have been a typo in with odata_filter being set equal to odata_filter and not odata_filters,
let me know if the new code proposal looks good to you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @federicocaccialanzaabb
Can you update code to make sure the tests are passing ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing, just a check for code coverage is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @logan-markewich,
can you advise me on how to test the code coverage ?
(I can't seem to find the test script to run in order to check the coverage, or any information on how to do so in the contributing file, nor the uv run --pytest include this test)
The commit is also small, I was not expecting it to impact code coverage percentage
I have run the following uv run pytest --cov tests/
and the results were higher than 50%:
tests/test_azureaisearch.py ........ [ 88%]
tests/test_vector_stores_cogsearch.py . [100%]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@federicocaccialanzaabb I'm not concerned about code coverage. But unit tests are failing -- but now they aren't, thanks!
…ps://github.com/federicocaccialanzaabb/llama_index into fix/llama-index-vector-stores-azureaisearch-fix
Description
Small change to fix odata filters being passed as kwargs to azure document client
Fixes # (issue)
refers to #19370
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)from version 0.4.0 to version 0.4.1
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods