-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Yugabytedb chat store #19768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yugabytedb chat store #19768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, I left some comments for potential improvements
llama-index-integrations/storage/chat_store/llama-index-storage-chat-store-yugabytedb/README.md
Outdated
Show resolved
Hide resolved
.../llama-index-storage-chat-store-yugabytedb/llama_index/storage/chat_store/yugabytedb/base.py
Outdated
Show resolved
Hide resolved
.../llama-index-storage-chat-store-yugabytedb/llama_index/storage/chat_store/yugabytedb/base.py
Outdated
Show resolved
Hide resolved
...dex-integrations/storage/chat_store/llama-index-storage-chat-store-yugabytedb/pyproject.toml
Outdated
Show resolved
Hide resolved
...ore/llama-index-storage-chat-store-yugabytedb/tests/test_chat_store_yugabytedb_chat_store.py
Outdated
Show resolved
Hide resolved
llama-index-integrations/storage/chat_store/llama-index-storage-chat-store-yugabytedb/README.md
Show resolved
Hide resolved
|
Also linting and testing are not passing. We will need to make them pass before merging |
|
@AstraBert I have made the changes, do take a look. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Thank you, @AstraBert, for merging the changes. |
|
@Sfurti-yb you can make a PR updating the docs for that page (the docs are in the repo here as well) |
|
@logan-markewich @AstraBert I have created a PR for the docs update. Do take a look. Thanks. |
* Add YugabyteDB as a Chat Store * Add yugabyte parameters to parse_uri function * Made changes as per review comments + Added potential fix for linting and test errors
Description
Hi, I am reaching out on behalf of YugabyteDB,a high-performance, PostgreSQL-compatible distributed database built for global, internet-scale applications.
This contribution adds support for YugabyteDB as a chat store in LlamaIndex. The implementation is based on the existing PostgreSQL chat store, with modifications and enhancements specific to YugabyteDB’s architecture including the usage of YugabyteDB smart driver.
We’d appreciate it if you could review the changes and guide us on the next steps to have YugabyteDB officially listed as a supported chat store in LlamaIndex
Looking forward to your feedback!
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
Note: We implemented the entire code again instead of just extending from the PostgresChatStore because extending the PostgresChatStore currently introduces psycopg as a transitive dependency. This creates a conflict with psycopg2-yugabytedb, our smart driver, which provides features such as load balancing to better leverage YugabyteDB’s distributed architecture.
However, if it is important for your use case that we directly inherit the PostgresChatStore code, we can make the necessary changes—though this would require removing certain smart driver features like load balancing.