Skip to content

Conversation

@logan-markewich
Copy link
Collaborator

Two fixes

  • anthropic not using CachePoint correctly
  • chroma get_nodes() fails with no node IDs -- seems it expects to have None instead of []

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 20, 2025
Copy link
Collaborator

@anoopshrma anoopshrma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2025
@anoopshrma
Copy link
Collaborator

Tests are not our Friend today 😞

@logan-markewich
Copy link
Collaborator Author

Yea I need to fix this test lol

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 21, 2025
@logan-markewich logan-markewich merged commit dd29801 into main Aug 21, 2025
11 checks passed
@logan-markewich logan-markewich deleted the logan/fix_anthropic_cache_point branch August 21, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants