Skip to content

Conversation

@orhankislal
Copy link
Contributor

@orhankislal orhankislal commented Aug 20, 2025

Add integration support for Azure PostgreSQL with the following additional features:

  • Microsoft Entra ID support
  • pg_diskann indexing support

The codebase has a common folder that might get refactored out of this repo and to a different package in the future.

Note that this PR contains repurposed code from the following repo: langchain-ai/langchain-azure@401da3f#diff-ed0e9cf3e9e87215e4408f495e0be3ca408796c28ae0428dcde8ca3839f4deb4

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

Add integration support for Azure PostgreSQL with the following additional features:

- Microsoft Entra ID support
- pg_diskann indexing support

The codebase has a common folder that might get refactored out of this repo and to a
different package in the future.

Note that this PR contains repurposed code from the following repo:
langchain-ai/langchain-azure@401da3f#diff-ed0e9cf3e9e87215e4408f495e0be3ca408796c28ae0428dcde8ca3839f4deb4
@orhankislal orhankislal marked this pull request as ready for review August 28, 2025 12:54
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Aug 28, 2025
@orhankislal
Copy link
Contributor Author

I am still working on the tests, but I wanted to open the PR up for reviews for faster iteration. I noticed that @AstraBert and @logan-markewich reviewed some of the recent large PRs, looking forward to your feedback. Please let me know if I should tag someone else as well.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AstraBert
Copy link
Member

Hey @orhankislal
I saw you put an src folder in your integration, and we generally do not do that... Just wanted to let you know before starting the review!
The correct pattern would be:

llama-index-integrations/vector-stores/llama-index-vector-stores-azure-postgresql/
|__README, LICENSE, Makefile etc.
|__llama_index/vector_stores/azure_postgresql/
     |__ __init__.py
     |__ subdirectory/
     |__ script.py
     ...

@orhankislal
Copy link
Contributor Author

Hey @orhankislal I saw you put an src folder in your integration, and we generally do not do that... Just wanted to let you know before starting the review! The correct pattern would be:

Hey @AstraBert thanks for the suggestion. I was following the pattern from this page: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/
I am happy to move it out as you suggested. Looking forward to your further feedback and suggestions.

@logan-markewich
Copy link
Collaborator

@orhankislal since we have a monorepo with namespaced imports, best to follow the structure @AstraBert recommended. All integrations in the repo follow this pattern

@orhankislal
Copy link
Contributor Author

@orhankislal since we have a monorepo with namespaced imports, best to follow the structure @AstraBert recommended. All integrations in the repo follow this pattern

Sure, I made the change as suggested.

"pydantic~=2.0",
# Needed for typing.Self in 3.10 and typing.override in 3.11
"typing-extensions~=4.0; python_version < '3.12'",
"llama-index-core~=0.13.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably this should be >=0.13,<0.15 these days

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but tests are failing. I think they are trying to connect to an actual DB? We will need to either skip these when a DB is not available or mock out the DB so that this works in CICD

@logan-markewich logan-markewich merged commit 2c853f8 into run-llama:main Sep 23, 2025
10 of 11 checks passed
frankiekim5 pushed a commit to frankiekim5/bedrock-agentcore-memory that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants