-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Add support for Azure PostgreSQL #19709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Azure PostgreSQL #19709
Conversation
Add integration support for Azure PostgreSQL with the following additional features: - Microsoft Entra ID support - pg_diskann indexing support The codebase has a common folder that might get refactored out of this repo and to a different package in the future. Note that this PR contains repurposed code from the following repo: langchain-ai/langchain-azure@401da3f#diff-ed0e9cf3e9e87215e4408f495e0be3ca408796c28ae0428dcde8ca3839f4deb4
|
I am still working on the tests, but I wanted to open the PR up for reviews for faster iteration. I noticed that @AstraBert and @logan-markewich reviewed some of the recent large PRs, looking forward to your feedback. Please let me know if I should tag someone else as well. |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hey @orhankislal |
Hey @AstraBert thanks for the suggestion. I was following the pattern from this page: https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/ |
|
@orhankislal since we have a monorepo with namespaced imports, best to follow the structure @AstraBert recommended. All integrations in the repo follow this pattern |
Sure, I made the change as suggested. |
| "pydantic~=2.0", | ||
| # Needed for typing.Self in 3.10 and typing.override in 3.11 | ||
| "typing-extensions~=4.0; python_version < '3.12'", | ||
| "llama-index-core~=0.13.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably this should be >=0.13,<0.15 these days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but tests are failing. I think they are trying to connect to an actual DB? We will need to either skip these when a DB is not available or mock out the DB so that this works in CICD
Add integration support for Azure PostgreSQL with the following additional features:
The codebase has a common folder that might get refactored out of this repo and to a different package in the future.
Note that this PR contains repurposed code from the following repo: langchain-ai/langchain-azure@401da3f#diff-ed0e9cf3e9e87215e4408f495e0be3ca408796c28ae0428dcde8ca3839f4deb4
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods