Skip to content

Fix evaluate crash when no images provided #19686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2025
Merged

Fix evaluate crash when no images provided #19686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions llama-index-core/llama_index/core/evaluation/multi_modal/faithfulness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,12 +150,14 @@ def evaluate(
context_str=context_str, query_str=response
)

image_nodes: List[Union[ImageBlock, TextBlock]] = []

if image_paths:
image_nodes: List[Any] = [
ImageBlock(path=Path(image_path)) for image_path in image_paths
]
image_nodes.extend(
[ImageBlock(path=Path(image_path)) for image_path in image_paths]
)
if image_urls:
image_nodes = [ImageBlock(url=image_url) for image_url in image_urls]
image_nodes.extend([ImageBlock(url=image_url) for image_url in image_urls])

image_nodes.append(TextBlock(text=fmt_prompt))

Expand Down
Loading