-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Update and fix cognee integration #19650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and fix cognee integration #19650
Conversation
This reverts commit c6c5e12.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
||
| [project] | ||
| name = "llama-index-graph-rag-cognee" | ||
| version = "0.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets bump this to 0.3.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, updating
|
Seems like we either need to mark some tests as skip if llm credentials are missing or mock out the llm calls? |
|
Apologies, I forgot to skip unit tests that rely on LLM credentials, let me update the PR |
|
Thanks for the efforts here! |
Description
Restored and enhanced the CogneeGraphRAG integration that was previously moved to stale packages due to broken tests. This change fixes the existing test issues and adds comprehensive test coverage to ensure the integration is robust and reliable.
The restored integration now includes:
The new test suite covers:
This addresses the issues mentioned in PR #19627 where tests were broken, making the integration production-ready again.
Fixes # (restores functionality from stale packages)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint godsRestoration Details
This PR addresses the issues that caused cognee to be moved to stale packages:
The new test suite includes:
test_empty_documents()- Tests handling of empty document lists and validates proper error handlingtest_single_document()- Tests processing single documents vs lists of documentstest_visualize_graph()- Tests graph visualization with different parameters and error conditionstest_search_error_handling()- Tests behavior when search methods return empty resultstest_mock_full_workflow()- Complete workflow test with mocked dependencies for offline testingtest_mixed_document_types()- Tests handling of mixed valid/invalid document typesThe integration is now ready for production use with reliable test coverage.