-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat:heroku llm integration #19576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:heroku llm integration #19576
Conversation
|
Hi there! Curious to know if there are any other actions we need to take to get this PR reviewed. Thanks! |
llama-index-integrations/llms/llama-index-llms-heroku/pyproject.toml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, just a few small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can delete this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @logan-markewich! 👋 It's not clear to me what you're referring to in this comment. Do you mean delete the entire file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, its not needed (we have the readme). If you really want an example we can throw a notebook into docs/docs/examples/llm
…t.toml Co-authored-by: Logan <[email protected]>
Description
The intention of these changes is to introduce Heroku integration and its usage within LLamaindex.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods