Skip to content

Conversation

@hrnayak66
Copy link
Contributor

@hrnayak66 hrnayak66 commented Jun 20, 2025

Description

This PR introduces a new cross_encoder_kwargs parameter to the SentenceTransformerRerank class. This allows users to pass additional configuration options directly to the underlying sentence_transformers.CrossEncoder model, providing greater flexibility for advanced use cases where need to change parameter like local_files_only, cache_dir etc

Fixes #18476

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 22, 2025
@logan-markewich logan-markewich merged commit 5b37dd2 into run-llama:main Jun 22, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Enable All CrossEncoder Settings

2 participants