Skip to content

Conversation

@AstraBert
Copy link
Member

Description

This PR makes the progress bar of TitleExtractor unified for all title extractions jobs instead of one per job.

Fixes #19129

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 18, 2025
title_jobs = [
self.llm.apredict(
return [
await self.llm.apredict(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this will run all title extractions sequentially per node instead of previously concurrently (I think)

Did we want to keep run_jobs but just disable progress since its a nested run_jobs call?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about sequentially vs concurrently, because in theory (from what I could see up to now) we still run one node per call of the function, so it should not make a great performance difference (?)
But I don't have a strong opinion of this, really, so we can also keep things as they were disabling the show_progress :))

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see what you mean. Yes technically no change in performance here from old->new

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 18, 2025
@logan-markewich logan-markewich merged commit c4b4ebf into main Jun 18, 2025
8 of 10 checks passed
@logan-markewich logan-markewich deleted the clelia/title-extractor-progress-bar branch June 18, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: TitleExtractor Progress Bar should be nested

2 participants