Skip to content

Conversation

@AstraBert
Copy link
Member

Description

In llama-index-vector-store-redis v0.5.1 we incorrectly check for the redis_client, so that the RedisVectorStore object cannot be loaded simply from a URL anymore. With this PR, we correct the redis client handling so that the client is instatiated from the URL, if the redis_client itself is not passed.

Fixes #18981

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@AstraBert AstraBert self-assigned this Jun 5, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 5, 2025
self._redis_client_async = redis_client_async
if redis_client or redis_url:
if redis_url and not redis_client:
redis_client = Redis(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use Redis.from_url() I think? Slightly safer

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup :)

@AstraBert AstraBert merged commit 303c0d3 into main Jun 5, 2025
10 checks passed
@AstraBert AstraBert deleted the clelia/redis-vector-store-correction branch June 5, 2025 17:41
@colca colca mentioned this pull request Jun 9, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot initialize RedisVectorStore with only redis_url since v0.5.1

3 participants