Skip to content

Conversation

@adrianlyjak
Copy link
Contributor

@adrianlyjak adrianlyjak commented Jun 1, 2025

Description

#18654 has a failure mode where the anthropic model current fails if there are no tools. Selecting tool choice "auto" without tools will cause a failure response from the anthropic API. This change modifies the implementation to no longer specify any tool choice configuration if there are no tools and tools are not required

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I added new integration tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

@adrianlyjak adrianlyjak force-pushed the anthropic-no-tools branch 2 times, most recently from 950cd6c to c492481 Compare June 1, 2025 18:09
@adrianlyjak adrianlyjak force-pushed the anthropic-no-tools branch from c492481 to 20b2165 Compare June 1, 2025 18:11
@adrianlyjak adrianlyjak marked this pull request as ready for review June 1, 2025 18:11
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 1, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 1, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) June 1, 2025 18:13
@logan-markewich logan-markewich merged commit 84c05c1 into main Jun 1, 2025
10 checks passed
@logan-markewich logan-markewich deleted the anthropic-no-tools branch June 1, 2025 18:14
@colca colca mentioned this pull request Jun 9, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants