mcp client upgrade #18833
Merged
mcp client upgrade #18833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dosubot
bot
added
the
size:XL
adrianlyjak
approved these changes
May 23, 2025
llama-index-integrations/tools/llama-index-tools-mcp/llama_index/tools/mcp/client.py
Show resolved
Hide resolved
llama-index-integrations/tools/llama-index-tools-mcp/tests/server.py
Outdated
Show resolved
Hide resolved
llama-index-integrations/tools/llama-index-tools-mcp/tests/test_client.py
Outdated
Show resolved
Hide resolved
llama-index-integrations/tools/llama-index-tools-mcp/tests/test_client.py
Outdated
Show resolved
Hide resolved
18 tasks
adrianlyjak
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HUGE update to our
BasicMCPClientsseandStreamable HTTP transportprotocolsSome notes:
get_prompt()return llama-index chat messages. This is a little debatable (should we just return the raw mcp types? Or are there more endpoints that can be converted into more use llama-index objects?)