Skip to content

Conversation

@thams
Copy link
Contributor

@thams thams commented May 7, 2025

Description

Fixes improper invocation of Firecrawl library

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested by hand.

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

Description

Args needed to be unpacked.
Call to get docs was incorrect.

Fixes # (issue)

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 7, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 7, 2025
@logan-markewich logan-markewich merged commit d5af21a into run-llama:main May 8, 2025
7 of 9 checks passed
@busaud
Copy link
Contributor

busaud commented May 12, 2025

This is actually a breaking change. I am getting:
Unsupported parameter(s) for crawl_url: scrapeOptions, allowExternalLinks, excludePaths, allowBackwardLinks, maxDepth, ignoreSitemap. Please refer to the API documentation for the correct parameters.

@logan-markewich
Copy link
Collaborator

@busaud I don't believe this is breaking, those are all valid params according to their type-hints
image

You maybe have to pip install -U firecrawl though?

@busaud
Copy link
Contributor

busaud commented May 15, 2025

@busaud I don't believe this is breaking, those are all valid params according to their type-hints
image

You maybe have to pip install -U firecrawl though?

I am using fresh installations by rebuilding my container.
But even when I downgrade, I still face another error so I assume I need to upgrade my Firecrawl container as I am self-hosting.

@logan-markewich
Copy link
Collaborator

@busaud most likely yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants