Skip to content

Add JRuby for Windows on Arm #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

Add JRuby for Windows on Arm #796

merged 1 commit into from
Aug 20, 2025
+12 −5

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Aug 12, 2025

@ntkme ntkme force-pushed the jruby-windows-arm branch from 7740164 to 9180418 Compare August 12, 2025 01:22
@ntkme
Copy link
Contributor Author

ntkme commented Aug 19, 2025 •
edited
Loading

@eregon Would you mind take a look? I can add test cases after the other two PRs are merged and builds are produced.

eregon
eregon reviewed Aug 20, 2025
View reviewed changes
common.js
arch = "X64"
}

// JAVA_HOME_21_AARCH64 - https://github.com/actions/partner-runner-images/blob/main/images/arm-windows-11-image.md#java
// JAVA_HOME_21_arm64 - https://github.com/actions/runner-images/blob/main/images/macos/macos-15-arm64-Readme.md#java
// JAVA_HOME_21_X64 - https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#java
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those links, this inconsistency knows no bounds 😅

@eregon
Copy link
Member

eregon commented Aug 20, 2025

Those are merged, and builds have been triggered, please add it to the test matrix

@ntkme ntkme force-pushed the jruby-windows-arm branch from 9180418 to c310551 Compare August 20, 2025 08:15
@ntkme
Copy link
Contributor Author

ntkme commented Aug 20, 2025

Tests added.

@eregon eregon merged commit efbf473 into ruby:master Aug 20, 2025
193 checks passed
mergify bot added a commit to robfrank/linklift that referenced this pull request Sep 2, 2025
@mergify
chore(deps): bump the github-actions group across 1 directory with 2 …
b8f3c81 
…updates [skip ci]

Bumps the github-actions group with 2 updates in the / directory: [github/codeql-action](https://github.com/github/codeql-action) and [ruby/setup-ruby](https://github.com/ruby/setup-ruby).
Updates `github/codeql-action` from 3.29.9 to 3.29.11
Release notes

*Sourced from [github/codeql-action's releases](https://github.com/github/codeql-action/releases).*

> v3.29.11
> --------
>
> CodeQL Action Changelog
> =======================
>
> See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs.
>
> 3.29.11 - 21 Aug 2025
> ---------------------
>
> * Update default CodeQL bundle version to 2.22.4. [#3044](https://redirect.github.com/github/codeql-action/pull/3044)
>
> See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v3.29.11/CHANGELOG.md) for more information.
>
> v3.29.10
> --------
>
> CodeQL Action Changelog
> =======================
>
> See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs.
>
> 3.29.10 - 18 Aug 2025
> ---------------------
>
> No user facing changes.
>
> See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v3.29.10/CHANGELOG.md) for more information.


Changelog

*Sourced from [github/codeql-action's changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md).*

> CodeQL Action Changelog
> =======================
>
> See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs.
>
> [UNRELEASED]
> ------------
>
> No user facing changes.
>
> 3.29.11 - 21 Aug 2025
> ---------------------
>
> * Update default CodeQL bundle version to 2.22.4. [#3044](https://redirect.github.com/github/codeql-action/pull/3044)
>
> 3.29.10 - 18 Aug 2025
> ---------------------
>
> No user facing changes.
>
> 3.29.9 - 12 Aug 2025
> --------------------
>
> No user facing changes.
>
> 3.29.8 - 08 Aug 2025
> --------------------
>
> * Fix an issue where the Action would autodetect unsupported languages such as HTML. [#3015](https://redirect.github.com/github/codeql-action/pull/3015)
>
> 3.29.7 - 07 Aug 2025
> --------------------
>
> This release rolls back 3.29.6 to address issues with language autodetection. It is identical to 3.29.5.
>
> 3.29.6 - 07 Aug 2025
> --------------------
>
> * The `cleanup-level` input to the `analyze` Action is now deprecated. The CodeQL Action has written a limited amount of intermediate results to the database since version 2.2.5, and now automatically manages cleanup. [#2999](https://redirect.github.com/github/codeql-action/pull/2999)
> * Update default CodeQL bundle version to 2.22.3. [#3000](https://redirect.github.com/github/codeql-action/pull/3000)
>
> 3.29.5 - 29 Jul 2025
> --------------------
>
> * Update default CodeQL bundle version to 2.22.2. [#2986](https://redirect.github.com/github/codeql-action/pull/2986)
>
> 3.29.4 - 23 Jul 2025
> --------------------
>
> No user facing changes.
>
> 3.29.3 - 21 Jul 2025
> --------------------
>
> No user facing changes.
>
> 3.29.2 - 30 Jun 2025
> --------------------
>
> * Experimental: When the `quality-queries` input for the `init` action is provided with an argument, separate `.quality.sarif` files are produced and uploaded for each language with the results of the specified queries. Do not use this in production as it is part of an internal experiment and subject to change at any time. [#2935](https://redirect.github.com/github/codeql-action/pull/2935)
>
> 3.29.1 - 27 Jun 2025
> --------------------

... (truncated)


Commits

* [`3c3833e`](github/codeql-action@3c3833e) Merge pull request [#3052](https://redirect.github.com/github/codeql-action/issues/3052) from github/update-v3.29.11-14148a433
* [`8c4bfbd`](github/codeql-action@8c4bfbd) Update changelog for v3.29.11
* [`14148a4`](github/codeql-action@14148a4) Merge pull request [#3044](https://redirect.github.com/github/codeql-action/issues/3044) from github/update-bundle/codeql-bundle-v2.22.4
* [`71b2cb3`](github/codeql-action@71b2cb3) Add changelog note
* [`2bf7825`](github/codeql-action@2bf7825) Update default bundle to codeql-bundle-v2.22.4
* [`db69a51`](github/codeql-action@db69a51) Merge pull request [#3049](https://redirect.github.com/github/codeql-action/issues/3049) from github/update-supported-enterprise-server-versions
* [`a68d47b`](github/codeql-action@a68d47b) Merge pull request [#3050](https://redirect.github.com/github/codeql-action/issues/3050) from github/henrymercer/init-not-called-config-error
* [`e496ff9`](github/codeql-action@e496ff9) Make "init not called" a configuration error
* [`fd2ea72`](github/codeql-action@fd2ea72) Update supported GitHub Enterprise Server versions
* [`6dee5bc`](github/codeql-action@6dee5bc) Merge pull request [#3045](https://redirect.github.com/github/codeql-action/issues/3045) from github/dependabot/npm\_and\_yarn/npm-5b4171dd16
* Additional commits viewable in [compare view](github/codeql-action@df55935...3c3833e)
  
Updates `ruby/setup-ruby` from 1.255.0 to 1.256.0
Release notes

*Sourced from [ruby/setup-ruby's releases](https://github.com/ruby/setup-ruby/releases).*

> v1.256.0
> --------
>
> What's Changed
> --------------
>
> * Bump actions/checkout from 4 to 5 by [`@​dependabot`](https://github.com/dependabot)[bot] in [ruby/setup-ruby#797](https://redirect.github.com/ruby/setup-ruby/pull/797)
> * Add JRuby for Windows on Arm by [`@​ntkme`](https://github.com/ntkme) in [ruby/setup-ruby#796](https://redirect.github.com/ruby/setup-ruby/pull/796)
>
> **Full Changelog**: <ruby/setup-ruby@v1.255.0...v1.256.0>


Commits

* [`efbf473`](ruby/setup-ruby@efbf473) Add JRuby for Windows on Arm
* [`bd28d36`](ruby/setup-ruby@bd28d36) Merge pull request [#797](https://redirect.github.com/ruby/setup-ruby/issues/797) from ruby/dependabot/github\_actions/actions/checkout-5
* [`3c08d92`](ruby/setup-ruby@3c08d92) Bump actions/checkout from 4 to 5
* See full diff in [compare view](ruby/setup-ruby@829114f...efbf473)
  
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore  major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore  minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore  ` will remove the ignore condition of the specified dependency and ignore conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntkme @eregon