Minor cleanup for ruby 2.7 warnings and failures. #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does, however, extend travis to include testing on 2.7. |
|
@hsbt bump? |
Signed-off-by: Ryan Davis <[email protected]>
Signed-off-by: Ryan Davis <[email protected]>
Immaculate test output! Signed-off-by: Ryan Davis <[email protected]>
zenspider
force-pushed
the
zenspider/ruby-2.7
branch
from
ca0ffa5 to
927c167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't as complete as #388, but it might be easier to take on at this point. I dunno. All I know is it cleans up all our use of json and our tests run w/o warnings now.