Support body_name in desc block #1832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I am wondering whether some of this should be configurable or externalized or more dynamic so that future things don't need these changes? But maybe I'm overthinking it. |
Contributor
Author
|
I made a similar thought but then again this should be a one-off migration from the (deprecated) options hash to the block syntax. I don't know how often these options change and whether making them configurable is justified. |
Member
|
Hi @fotos … this deprecation stuff is in since a while, so thanks to have an eye … can it also be done, by making it possible to overwrite |
basjanssen
pushed a commit
to basjanssen/grape
that referenced
this pull request
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
body_nameindescblock.Already described in
grape-swagger.Related to #1791.