make the pruning of thread pools a public API #761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR! I'll have a careful look. I'll also need to look into the java part, I'd like the behavior to match. |
Contributor
Author
|
Ping ? |
pitr-ch
reviewed
Jan 3, 2019
This makes the pruning of thread pools a public API, which may or may not be a no-op, depending on the underlying thread pool implementation. It also reworks the Ruby implementation to be more aggressive in the pruning - it will kill all to-be-pruned threads in one call instead of doing them one by one. Moreover, workers do not get woken up to check for their idleness anymore, the thread of the caller does it instead.
Contributor
Author
|
@pitr-ch updated. Sorry for taking so long. |
Member
|
@doudou thank you. And no worries, I appreciate you've found time to contribute. |
Contributor
Author
|
Gents ... any chance this could be included ? |
Member
|
We'll see if we can merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the pruning of thread pools a public API, which may
or may not be a no-op, depending on the underlying thread pool
implementation.
It also reworks the Ruby implementation to be more aggressive in
the pruning - it will kill all to-be-pruned threads in one call
instead of doing them one by one. Moreover, workers do not get
woken up to check for their idleness anymore, the thread of the
caller does it instead.
Closes #652