Fix error handling in edge promises #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now properly handles errors raised within deeply nested futures. * `value!` now properly works with `rejected_future` Fixes ruby-concurrency#659
Contributor
Author
|
@pitr-ch ping |
pitr-ch
approved these changes
Jul 23, 2017
Member
pitr-ch
left a comment
pitr-ch
left a comment
There was a problem hiding this comment.
Thank you very much for the fix and sorry I did not get to it sooner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
value!now properly works withrejected_futureFixes #659