#inspect should not output negative object IDs. #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meineerde
added a commit
to meineerde/rackstash
that referenced
this pull request
Jul 18, 2017
Sometimes, object_ids are created as signed Integers which are invalid in `inspect`. By using the default implementation of `Object#to_s`, we can get valid object_ids the same way Ruby itself would have created them. For a motivation of this change, see * https://bugs.ruby-lang.org/issues/13397 * ruby-concurrency/concurrent-ruby#651
It might happen that object ID is 'negative', since Ruby tries to avoid Bignums: https://bugs.ruby-lang.org/issues/13397
ghost
assigned
pitr-ch
approved these changes
Feb 21, 2018
Member
|
Thanks @voxik, rebasing and merging when CI passes |
This was referenced Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might happen that object ID is 'negative', since Ruby tries to avoid Bignums:
https://bugs.ruby-lang.org/issues/13397
However, I am not sure if this does not break any precondition for the fec11e7 commit which introduced one of the #inspect methods. But I am using Kernel#to_s (as suggested by @nobu) instead of #inspect, so hopefully this is correct ...