Fixes format-security error when compiling ruby_193_compatible.h #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RJPercival
force-pushed
the
format-security-error
branch
from
19c0b4b to
316e043
Compare
ext/concurrent/ruby_193_compatible.h
Outdated
| err_mess = rb_sprintf("wrong number of arguments (%d for %d..%d)", argc, min, max); | ||
| } | ||
| rb_raise(rb_eTypeError, err_mess); | ||
| return rb_ext_new3(rb_eTypeError, err_mess); |
Contributor
There was a problem hiding this comment.
Where did you find the documentation on rb_ext_new3?
Contributor
Author
There was a problem hiding this comment.
Oops, that's supposed to be rb_exc_new3 - fixed.
Contributor
Author
There was a problem hiding this comment.
I'm surprised the Travis build succeeded. It looks like the extension is being compiled with very lenient settings, to the extent that calling non-existent functions isn't even considered an error!
When compiling the extension for Ruby 1.9 on a system that treats format-security warnings as errors (i.e. the Makefile generated for the extension contains "-Werror=format-security"), compilation would fail with the following error:
```
compiling atomic_boolean.c
In file included from atomic_boolean.c:5:0:
ruby_193_compatible.h: In function 'rb_error_arity':
ruby_193_compatible.h:20:3: warning: passing argument 2 of 'rb_raise' makes pointer from integer without a cast [enabled by
default]
rb_raise(rb_eTypeError, err_mess);
^
In file included from /usr/include/ruby-1.9.1/ruby.h:32:0,
from atomic_boolean.c:1:
/usr/include/ruby-1.9.1/ruby/ruby.h:1172:27: note: expected 'const char *' but argument is of type 'VALUE'
PRINTF_ARGS(NORETURN(void rb_raise(VALUE, const char*, ...)), 2, 3);
^
/usr/include/ruby-1.9.1/ruby/ruby.h:42:3: note: in definition of macro 'PRINTF_ARGS'
decl __attribute__((format(printf, string_index, first_to_check)))
^
/usr/include/ruby-1.9.1/ruby/ruby.h:1172:13: note: in expansion of macro 'NORETURN'
PRINTF_ARGS(NORETURN(void rb_raise(VALUE, const char*, ...)), 2, 3);
^
In file included from atomic_boolean.c:5:0:
ruby_193_compatible.h:20:3: error: format not a string literal and no format arguments [-Werror=format-security]
rb_raise(rb_eTypeError, err_mess);
^
cc1: some warnings being treated as errors
make: *** [atomic_boolean.o] Error 1
```
This updates these functions to work more like the original copies (found in the Ruby 2.0+ source code), which avoids this compilation error.
RJPercival
force-pushed
the
format-security-error
branch
from
316e043 to
b3fa771
Compare
Member
|
@RJPercival Thanks very much for the fix. I'll defer to @jdantonio for review though. |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #516. When compiling the extension for Ruby 1.9 on a system that treats format-security warnings as errors (i.e. the Makefile generated for the extension contains "-Werror=format-security"), compilation would fail with the following error:
This updates the functions in ruby_193_compatible.h to work more like the original copies (found in the Ruby 2.0+ source code), which avoids this compilation error.