Fix Future#flat when failures happen

[pitr-ch]

fix #426

[hobodave]

I think this should be Concurrent.future { Concurrent.future { raise 'boo' } }.flat since #flat is expecting to be returned a future. (Or add this case as an additional test)

[pitr-ch]

yeah it should be a separate example, I was lazy.

[hobodave]

Thanks for this @pitr-ch! I'm testing it now in our real-world use case.

[pitr-ch]

@hobodave great! Btw since this is an edge feature we are looking for a feedback about the API before it finalises and goes to concurrent core. If you have any suggestions, insights, please share.

[hobodave]

What would be the best mechanism to share API feedback? Creating issues?

[pitr-ch]

@hobodave yeah please create an issue.

[jdantonio]

@pitr-ch Will you be merging this today? I'd like to publish the next pre-release today.

[pitr-ch]

@jdantonio just waiting for @hobodave to confirm that it fixes the issues for him, after that it can be merged.

[hobodave]

Confirmed 👍