Skip to content

Fix sporadic failures testing with JRuby #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2023
Merged

Fix sporadic failures testing with JRuby #1012

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f746228
Wait for blockers to proceed
headius Nov 7, 2023
ada6288
Bump join timeout up for slower system
headius Nov 7, 2023
a8fa486
Use repeat_until_success to wait for waiters
headius Nov 8, 2023
27f7833
Also skip on JRuby until we can fix sporadic failures
headius Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spec/concurrent/atomic/cyclic_barrier_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ module Concurrent
end

start_latch.wait(1)
Thread.pass until barrier.number_waiting == 1
barrier.reset

expect(barrier).not_to be_broken
Expand Down
2 changes: 1 addition & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def requires=(paths)
config.after :each do
while defined?(@created_threads) && @created_threads && (thread = (@created_threads.pop(true) rescue nil))
thread.kill
thread_join = thread.join(1.0)
thread_join = thread.join(10.0)
expect(thread_join).not_to be_nil, thread.inspect
end
end
Expand Down