fix: some nested cross-origin iframes can't be recorded #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4b0f07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
approved these changes
Dec 4, 2023
YunFeng0817
force-pushed
the
fix-cross-origin-iframe
branch
from
2d25969 to
40d99a9
Compare
Juice10
approved these changes
Jun 7, 2024
This was referenced Jun 7, 2024
jeffdnguyen
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Jul 29, 2024
* fix: some nested cross-origin iframes can't be recorded * fix building error in rrweb-player * add test case for this special case * Apply formatting changes --------- Co-authored-by: YunFeng0817 <[email protected]>
jeffdnguyen
pushed a commit
to pendo-io/rrweb
that referenced
this pull request
Jul 29, 2024
* fix: some nested cross-origin iframes can't be recorded * fix building error in rrweb-player * add test case for this special case * Apply formatting changes --------- Co-authored-by: YunFeng0817 <[email protected]>
jxiwang
pushed a commit
to amplitude/rrweb
that referenced
this pull request
Oct 22, 2024
* fix: some nested cross-origin iframes can't be recorded * fix building error in rrweb-player * add test case for this special case * Apply formatting changes --------- Co-authored-by: YunFeng0817 <[email protected]>
billyvg
pushed a commit
to getsentry/rrweb
that referenced
this pull request
Jan 23, 2025
* fix: some nested cross-origin iframes can't be recorded * fix building error in rrweb-player * add test case for this special case * Apply formatting changes --------- Co-authored-by: YunFeng0817 <[email protected]>
billyvg
added a commit
to getsentry/rrweb
that referenced
this pull request
Feb 10, 2025
Upstream rrweb-io#1353 * fix: some nested cross-origin iframes can't be recorded * fix building error in rrweb-player * add test case for this special case --------- Co-authored-by: Yun Feng <[email protected]> Co-authored-by: YunFeng0817 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a corner case bug in the recording functionality for pages with nested iframes.
The issue occurs when there is a specific frame structure:
In this scenario, the cross-origin iframe nested inside the same-origin iframe is not being recorded at all. This pull request fixes the recording behavior to properly capture the content of the cross-origin iframe.