Draft: feat: pool options #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisrei
reviewed
Jun 24, 2025
| @@ -150,7 +150,7 @@ impl Builder { | |||
| let mut lock = instances.0.write().await; | |||
|
|
|||
| for db in config.preload { | |||
| let pool = DbPool::connect(&db, app).await?; | |||
| let pool = DbPool::connect(&db, app, None).await?; | |||
There was a problem hiding this comment.
ik zou verwachten dat deze niet standaard None is maar uit de app config komt uit het veld Option
There was a problem hiding this comment.
this is a different init path which isn't supported/ relevant for now
| } | ||
| } | ||
|
|
||
| Ok(Self::Sqlite(pool_options.connect(conn_url).await?)) |
There was a problem hiding this comment.
gaat dit goed als 1 van de 2 optional fields leeg is?
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update to tauri 2.8.0 * fmt * uipdate build * tauri 2.8.1 and bump toml in plugin-fs * tauri 2.8.1 * 2.8.2 * clippy [skip ci] --------- Co-authored-by: Tony <[email protected]>
…2929) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ps#2923) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2930) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* feat: android deeplinks * feat: explicit app link declarations * feat: add ios code * fix: add ios deeplink adaptation * feat: ios working (some swift plugin api improvements needed) * fix: revert ios to prior logic * fix(cleanup): regen android files with old names * fix: web link criteria * fix: conditional auto verify intent filter for android app links * fix: default to true * fix: typo * fix: pnpm version * cleanup * fix: web link regression * trim androidmanifest update * fix deep link validation broken due to appLink=true default * implement update_info_plist from tauri-apps/tauri#13888 * fix: remove old patch crates * fix: use latest patch tauri * lint --------- Co-authored-by: Lucas Nogueira <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: FabianLars <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…i-apps#2905) * Converts NotificationSchedule enum to a dictionary to fix crash while scheduleing notifications. * change file --------- Co-authored-by: Lucas Nogueira <[email protected]>
) * Add sound support for desktop notifications in Tauri v2 * ci --------- Co-authored-by: Lucas Nogueira <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…2932) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…tauri-apps#2950) * fix(shell): run sidecar with dots in filename, closes tauri-apps#2310 * fix import * remove dead code * code review suggestions * clippy * clippy
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…2955) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ps#2956) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* fallback targets * linux test * linux ready * RPM installation * small error fix * fix windows build * windows tests * add aider files to .gitignore * get bundle type out of patched variable * windows tests * patch windows binary * format * fix bundler * remove local tauri dependency * remove print * rever Cargo.lock * move __TAURI_BUNDLE_TYPE to tauri::utils * get_current_bundle_type * update tauri * fix macos integration test * fix fallback logic Signed-off-by: Krzysztof Andrelczyk <[email protected]> * amend! fallback targets fallback targets * reformat * fix tests * reformat * bump tari versio * fix fallback logic * restore Cargo.lock * Bump tauri and add notes * Rename some staffs * move target logic * Refactor the target fallback to a function * Format and clippy * Keep target in `Update` since it's public * Keep updater/tests/app-updater/src/main.rs lf * Revert changes in tests/app-updater/src/main.rs * Clean up * changefile * Bump updater-js as well * update pub fn target docs * update pub fn target docs * Update plugins/updater/src/error.rs Co-authored-by: Fabian-Lars <[email protected]> * Update plugins/updater/src/updater.rs Co-authored-by: Fabian-Lars <[email protected]> * Update plugins/updater/src/updater.rs Co-authored-by: Fabian-Lars <[email protected]> * suggestios * add comment * restore error * Revert "Bump tauri and add notes" This reverts commit 0a495cc. * Revert "bump tari versio" This reverts commit 5b4c1c1. --------- Signed-off-by: Krzysztof Andrelczyk <[email protected]> Co-authored-by: Lucas Nogueira <[email protected]> Co-authored-by: Tony <[email protected]> Co-authored-by: Fabian-Lars <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on tauri-apps#2553