-
Notifications
You must be signed in to change notification settings - Fork 180
Vendor rcl_interfaces as a private module into rclrs #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fa688e0 to
4d09e19
Compare
|
LGTM, but I'll leave it to @jhdcs to approve it as I see that CI is failing. @nnmm can you update the description of this PR and add a docstring to the Python script with a description of what it does and how to use it? Thanks For a future PR, or maybe even this one, I'd add the test_interfaces messages so that we can integrate the tests here, I prefer tests to be in the same crate/package, they are easier to maintain and also serve as examples of how to use the API |
|
@esteve I had planned to just create an alias |
The parameter services require the rcl_interfaces message and service types.
4d09e19 to
53a4047
Compare
jhdcs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me as well, though I don't see a failing CI. Was that a previous commit?
…need to be present when rclrs is built and run
|
@jhdcs Could you reapprove this? I've added a commit to add these dependencies to |
|
Thanks! |
The parameter services require the rcl_interfaces message and service types. I think this option is preferable to publishing rcl_interfaces on crates.io.
The script included in this PR produces the
vendormodule insiderclrsby copying the generated code for thercl_interfacespackage and its dependencybuiltin_interfacesand adjusting the submodule paths in the code.If these packages, or the
rosidl_generator_rspackage, get changed, we can update thevendormodule by running this script.