Fix a segfault when re-using wait set #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnmm
force-pushed
the
fix_waitset_segfault
branch
from
43b345a to
f584990
Compare
esteve
previously approved these changes
Oct 11, 2022
nnmm
force-pushed
the
fix_waitset_segfault
branch
from
f584990 to
1bbb622
Compare
Contributor
Author
Collaborator
|
@nnmm yeah, I agree, using an application to drive features is an excellent way of finding out what's missing and what can be improved |
esteve
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rcl_wait()modifies the entries inrcl_wait_set.subscriptionsso that some of them will be null pointers, causing a segfault if called a second time.As a short term-fix, this makes it so that the wait set can only be used once.
The wait set should be made reusable as part of #278