Add workaround for text properties #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Could you uncomment the load guard, please? That said, I am not 100% sure about the compatibility of vim-cool with 7.4. I will have to double check. |
Whoops! Sorry, yes will do, in a couple of hours. |
nickspoons
force-pushed
the
text-property-bug
branch
from
4298d50 to
488b510
Compare
|
I uncommented the load guard, and amended the previous commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a reasonably long-standing bug in Vim affecting
:gotoandline2byte()when text properties are present on a line: vim/vim#5930This results in
exe 'goto' line2byte(...)always ending on the column1of the expected line, which means breaks vim-cool when there is more than one match on a line.This PR uses code from this workaround (Apache licensed, so I believe it's fine to copy) on lines containing text properties.