Skip to content

Conversation

@piotrgradzinski
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
License MIT

Adding polish (pl) translation for validators.

@michalbiarda
Copy link

@piotrgradzinski You will not believe this, but I just started translating the same file and then thought "meh, maybe someone already did it". Thanks! :-)

@michalbiarda
Copy link

michalbiarda commented May 6, 2021

@piotrgradzinski BTW. There is one bug in your translation:

<source>Your password must include at least one letter.</source>
<target>Hasło musi składać się z przynajmniej jednego znaku.</target>

It should be "Hasło musi zawierać przynajmniej jedną literę."

@piotrgradzinski
Copy link
Contributor Author

@michalbiarda - thank you very much for this! I've fixed that. On the other hand it would be great if you could take a look on the whole file. Just in case... It would be very valuable! Thank you!

@michalbiarda
Copy link

@piotrgradzinski I did! The only thing that I would change is:

<source>Your password must be at least {{length}} characters long.</source>
<target>Hasło musi składać się z przynajmniej {{length}} znaków.</target>

"Hasło musi zawierać przynajmniej {{length}} znaków." would be IMO much more consistent with other sentences :-).

@piotrgradzinski
Copy link
Contributor Author

@michalbiarda - thank you once again. I was thinking about the point you've raised and I would stay with the initial proposition - I've consulted this as well with polish philologist to make sure. This particular sentence relates to the password as a whole, thats why I've used składać się, whereas the other ones refer more to what password should contain (zawierać). Like the whole password must have at least X characters vs. within the whole password we need to have characters from the specific character class. Hope this makes sense :)

@michalbiarda
Copy link

@piotrgradzinski Sounds legit! 👍

@piotrgradzinski
Copy link
Contributor Author

@sstok just wanted to say that the PR looks good and can be merged if you don't mind. Thank you!

@sstok sstok merged commit 9c3dde3 into rollerworks:master May 7, 2021
@sstok
Copy link
Member

sstok commented May 7, 2021

Thank you @piotrgradzinski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants