Skip to content

Conversation

harveysanders
Copy link
Collaborator

@harveysanders harveysanders commented Dec 31, 2022

Description

Now one can run the application via the CLI or straight binary. The CLI allows the user to set configuration from a series of prompts. The server application use env vars for configuration.

Additionally, the application had a few bugs and would not start:

panic: token client must not be nil

Fix here

panic: chi: all middlewares must be defined before routes on a mux

Fix here

Current status

  • Waiting for review
  • Waiting for comment resolution
  • Waiting for merge
  • Draft
  • Trivial PR (nominal cosmetic/typo/whitespace changes)

How Has This Been Tested?

Manual

  • Ran server from VSCode launch.json debug config
    image
  • Shell
$ PORT=9999 go run ./cmd/server/main.go     

2022/12/31 14:16:05 App server starting on :9999

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code/docs and corrected any misspellings

@harveysanders harveysanders changed the base branch from main to dev December 31, 2022 19:18
@harveysanders harveysanders merged commit b32f004 into dev Dec 31, 2022
@harveysanders harveysanders deleted the chore/split-cli-server-cmds branch January 1, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants