Skip to content

Conversation

hardikdava
Copy link
Contributor

Description

This PR is implementation of #250

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Google colab link: https://colab.research.google.com/drive/1RNvsVWpkklUMZy5cjRs9y5yzBSHU9KRi?usp=sharing

Docs

  • Docs updated? What were the changes: docs/supervision/detection/tools/slicer.md

@hardikdava hardikdava added the version 0.14.0 Feature to be added in `0.14.0` release label Aug 12, 2023
@SkalskiP
Copy link
Collaborator

Hi @hardikdava 👋🏻 Is it ready for review?

@hardikdava
Copy link
Contributor Author

@SkalskiP Yeah, it is ready for review.

@hardikdava hardikdava marked this pull request as ready for review August 15, 2023 14:13
@SkalskiP
Copy link
Collaborator

@hardikdava I tried to run Notebook but it crashed. Is it up to date?

@hardikdava
Copy link
Contributor Author

@SkalskiP Ohh, it is an issue of image downloading.

@hardikdava
Copy link
Contributor Author

bird (2)

@SkalskiP Can you manually upload this image for testing? It should work. I just tested it.

@onuralpszr
Copy link
Contributor

onuralpszr commented Aug 15, 2023

@SkalskiP @hardikdava

raw URL good for wget : https://raw.githubusercontent.com/spmallick/learnopencv/master/Exploring-Slicing-Aided-Hyper-Inference/test_images/bird.jpg

Tip info : https://stackoverflow.com/questions/4604663/download-single-files-from-github/4605068#4605068

!wget 'https://raw.githubusercontent.com/spmallick/learnopencv/master/Exploring-Slicing-Aided-Hyper-Inference/test_images/bird.jpg'

from IPython.display import Image, display
display(Image('/content/bird.jpg'))

@hardikdava
Copy link
Contributor Author

@SkalskiP It is updated now!, it is working. Thanks @onuralpszr

@onuralpszr
Copy link
Contributor

@SkalskiP It is updated now!, it is working. Thanks @onuralpszr

You're welcome :) I am glad to help

@SkalskiP
Copy link
Collaborator

Hi @hardikdava 👋🏻 I'd add some unit tests to this PR. I can do that if ou don't have time.

@SkalskiP SkalskiP self-requested a review August 16, 2023 10:39
@SkalskiP SkalskiP added this to the version: 0.14.0 milestone Aug 16, 2023
@SkalskiP SkalskiP linked an issue Aug 16, 2023 that may be closed by this pull request
2 tasks
@SkalskiP
Copy link
Collaborator

Hi @hardikdava 👋🏻 I will work on a few unit tests before merging.

@hardikdava
Copy link
Contributor Author

@SkalskiP Thanks for covering some tasks for me.

@SkalskiP
Copy link
Collaborator

@hardikdava can I only ask one question? Why is _offset_generation producing offsets with 4 coordinates and not just two? I would assume we could move boxes with just x and y vectors.

@hardikdava
Copy link
Contributor Author

@SkalskiP yeah, we can do it with just x and y.

@SkalskiP
Copy link
Collaborator

I'll try to do some minor changes when I'll be working on tests.

@SkalskiP
Copy link
Collaborator

@hardikdava slicer looks fantastic!

Screen.Recording.2023-08-29.at.18.17.27.mov

@hardikdava
Copy link
Contributor Author

Looks really Amazing :)

@SkalskiP SkalskiP merged commit 85de9b2 into roboflow:develop Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version 0.14.0 Feature to be added in `0.14.0` release
Projects
Status: Current Release: Done
Development

Successfully merging this pull request may close these issues.

Feature/Sliced Detection
3 participants