Skip to content

Conversation

onuralpszr
Copy link
Contributor

@onuralpszr onuralpszr commented Sep 19, 2024

Description

Hello, 👋 , After long testing,user experiences and problems, we decided to remove opencv-python-headless package from supervision and using full version opencv, it is easy swap headless version If user desired to or wants to use distro version of opencv if wished to, we had so many cases bring more problem than gain and I think around 20mb~ bigger package won't be a big problem as well. Thank you so much

Related
#1522
#351
#556

@onuralpszr onuralpszr added the bug Something isn't working label Sep 19, 2024
@onuralpszr onuralpszr requested a review from LinasKo September 19, 2024 13:38
@onuralpszr onuralpszr self-assigned this Sep 19, 2024
Copy link
Contributor

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com. If commits are added to the pull request, synchronize your local branch: git pull origin feature/pip-package-configuration

@onuralpszr onuralpszr force-pushed the feature/pip-package-configuration branch from 7857c51 to 9be2fdf Compare September 19, 2024 14:02
Copy link
Contributor

@LinasKo LinasKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the lockfile needs to be updated as well.

Upon freshly cloning it and attempting to install the deps, here's what I get:

pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.

@onuralpszr onuralpszr force-pushed the feature/pip-package-configuration branch from 06fc8b0 to 4644f21 Compare September 19, 2024 14:42
@onuralpszr onuralpszr requested a review from LinasKo September 19, 2024 14:48
@onuralpszr
Copy link
Contributor Author

@LinasKo tests are done, index.md corrected (with some small ui fix), merge complete, lock file done as well.

Copy link
Contributor

@LinasKo LinasKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I installed, ran the tests, and built the docs, spotting no regressions.

Good catch regarding the index page.

I saw some changes in markdown formatting, but that's fine.

@LinasKo
Copy link
Contributor

LinasKo commented Sep 19, 2024

Merging. Thank you @onuralpszr!

@LinasKo LinasKo merged commit 784191a into develop Sep 19, 2024
9 checks passed
@onuralpszr
Copy link
Contributor Author

docs preview

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants