-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: 🐞 removal of opencv-python-headless package #1530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PreviewPreview and run these notebook edits with Google Colab:
git pull origin feature/pip-package-configuration
|
Signed-off-by: Onuralp SEZER <[email protected]>
7857c51
to
9be2fdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the lockfile needs to be updated as well.
Upon freshly cloning it and attempting to install the deps, here's what I get:
pyproject.toml changed significantly since poetry.lock was last generated. Run `poetry lock [--no-update]` to fix the lock file.
Signed-off-by: Onuralp SEZER <[email protected]>
06fc8b0
to
4644f21
Compare
@LinasKo tests are done, index.md corrected (with some small ui fix), merge complete, lock file done as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I installed, ran the tests, and built the docs, spotting no regressions.
Good catch regarding the index page.
I saw some changes in markdown formatting, but that's fine.
Merging. Thank you @onuralpszr! |
Description
Hello, 👋 , After long testing,user experiences and problems, we decided to remove opencv-python-headless package from supervision and using full version opencv, it is easy swap headless version If user desired to or wants to use distro version of opencv if wished to, we had so many cases bring more problem than gain and I think around 20mb~ bigger package won't be a big problem as well. Thank you so much
Related
#1522
#351
#556