Skip to content

Conversation

onuralpszr
Copy link
Contributor

Description

This PR adds support for keypoints support for detectron2 model

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

https://colab.research.google.com/drive/19nA7-MZQbPPMhtBbpMEpmRcpemwqSatJ?usp=sharing

Docs

  • Docs updated? What were the changes:

@onuralpszr onuralpszr added enhancement New feature or request api:keypoints labels Jun 26, 2024
@onuralpszr onuralpszr self-assigned this Jun 26, 2024
@onuralpszr onuralpszr requested a review from LinasKo June 26, 2024 13:31
@LinasKo
Copy link
Contributor

LinasKo commented Jul 5, 2024

I ran the colab with im = np.zeros((640, 640, 3), dtype=np.uint8).

The from_detectron2 function threw this error:
ValueError: xy must be a 2D np.ndarray with shape ((0, 0),), but got shape (0, 17, 2).

Could you look into that?

@onuralpszr
Copy link
Contributor Author

I ran the colab with im = np.zeros((640, 640, 3), dtype=np.uint8).

The from_detectron2 function threw this error: ValueError: xy must be a 2D np.ndarray with shape ((0, 0),), but got shape (0, 17, 2).

Could you look into that?

Sure let me check it. I didn't see this comment ( missed or didn't get notify from email or github at mobile sorry)

@onuralpszr
Copy link
Contributor Author

@LinasKo empty case fixed. sorry for late response legit did not see it.

Copy link
Contributor

@LinasKo LinasKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are small imperfections with the Colab, but overall it looks good!

Thank you @onuralpszr!

@LinasKo LinasKo merged commit 5d4abe6 into roboflow:develop Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:keypoints enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants