initial commit adding support for from_lmm and specifically for Pal…
#1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merveenoyan
reviewed
May 22, 2024
| ```python | ||
| import supervision as sv | ||
|
|
||
| paligemma_result = "<loc0256><loc0256><loc0768><loc0768> cat" |
There was a problem hiding this comment.
I think this would be also useful for models like KOSMOS-2 so best to make it very general (this is a trend with VLMs these days) https://huggingface.co/docs/transformers/en/model_doc/kosmos-2#transformers.Kosmos2ForConditionalGeneration.forward.example
There was a problem hiding this comment.
So what I want to do is one from_lmm function, providing separate dedicated parsers for each model. :)
…m_paligemma_support # Conflicts: # supervision/detection/lmm.py # test/detection/test_lmm.py
|
@SkalskiP, very quick one: I've just noticed that |
|
@LinasKo Good catch! I just fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for
from_lmmand specifically forPaliGemma.