This repository was archived by the owner on Oct 22, 2025. It is now read-only.
ci: fix pkg-pr-new #1001
Closed
ci: fix pkg-pr-new #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2025
Closed
NathanFlurry
force-pushed
the
06-21-ci_fix_pkg-pr-new
branch
2 times, most recently
from
c9fcd07 to
3b1c0c5
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
.github/workflows/pkg-pr-new.yaml
Outdated
| - run: yarn dlx pkg-pr-new publish 'packages/**/platforms/*' 'packages/*' 'packages/frameworks/*' --template './templates/*' --packageManager yarn | ||
| - run: pnpm install | ||
| - run: pnpm build | ||
| - run: pnpm dlx pkg-pr-new publish --packageManager pnpm |
There was a problem hiding this comment.
The pkg-pr-new publish command is missing the package paths that were specified in the original command. The previous implementation included:
'packages/**/platforms/*' 'packages/*' 'packages/frameworks/*' --template './templates/*'
Without these path arguments, the command may not publish the intended packages or might not publish anything at all. Consider adding these paths back to ensure the correct packages are published.
Suggested change
| - run: pnpm dlx pkg-pr-new publish --packageManager pnpm | |
| - run: pnpm dlx pkg-pr-new publish 'packages/**/platforms/*' 'packages/*' 'packages/frameworks/*' --template './templates/*' --packageManager pnpm |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
NathanFlurry
force-pushed
the
06-20-chore_remove_outdated_demos
branch
from
6cdbb14 to
8ff76b8
Compare
NathanFlurry
force-pushed
the
06-21-ci_fix_pkg-pr-new
branch
from
3b1c0c5 to
1d5e4fd
Compare
NathanFlurry
force-pushed
the
06-21-ci_fix_pkg-pr-new
branch
from
1d5e4fd to
25fcfdf
Compare
jog1t
force-pushed
the
06-20-chore_remove_outdated_demos
branch
from
8ff76b8 to
d7f764f
Compare
jog1t
force-pushed
the
06-21-ci_fix_pkg-pr-new
branch
from
25fcfdf to
1f22684
Compare
This was referenced Jun 23, 2025
Closed
Closed
Closed
This was referenced Jun 26, 2025
jog1t
force-pushed
the
06-20-chore_remove_outdated_demos
branch
from
8ff76b8 to
d7f764f
Compare
jog1t
force-pushed
the
06-21-ci_fix_pkg-pr-new
branch
from
25fcfdf to
1f22684
Compare
Draft
NathanFlurry
force-pushed
the
06-20-chore_remove_outdated_demos
branch
from
d7f764f to
8ff76b8
Compare
NathanFlurry
force-pushed
the
06-21-ci_fix_pkg-pr-new
branch
from
1f22684 to
25fcfdf
Compare
This was referenced Jun 27, 2025
Closed
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.