feat: automatically sanitise usernames on create/update #424
+169
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: higgs01 <[email protected]>
Signed-off-by: higgs01 <[email protected]>
IAmTomahawkx
requested changes
Aug 3, 2025
| // sanitise homoglyphs | ||
| let options = decancer::Options::default() | ||
| .retain_capitalization(); | ||
| let mut username = decancer::cure(&username, options).unwrap().to_string(); |
There was a problem hiding this comment.
Suggested change
| let mut username = decancer::cure(&username, options).unwrap().to_string(); | |
| let mut username = decancer::cure(username, options).unwrap().to_string(); |
Comment on lines
+316
to
318
| if BLOCKED_USERNAME_PATTERNS.is_match(&username) { | ||
| username = BLOCKED_USERNAME_PATTERNS.replace_all(&mut username, "").into_owned(); | ||
| } |
There was a problem hiding this comment.
Running the regex twice seems redundant. replace_all has no performance hit if a match isn't found.
| username.push_str(&"_".repeat(username_length_diff)) | ||
| } | ||
|
|
||
| (original_username != username, username) |
There was a problem hiding this comment.
returning a boolean here is strange considering its usages already hold the original name, and it can simply be checked out there.
github-project-automation
bot
moved this from 🆕 Untriaged
to 🛑 Changes requested
in Pull Request Overview
|
Making the min length configurable would just be a matter of adding an entry into revolt_config's models and the built-in Revolt.toml, then calling |
|
Thanks for the review - I'll probably get to looking at it next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #257
This PR contains the following:
display_nameis set to the username originally provided by the user_1.6.2to3.3.3to facilitate preserving capitalisation on sanitisationIn the Issue it was mentioned that it might be a good idea to make the min-length of the username configurable. I left this out of this PR for now, since I don't see a nice was to do this. If you've got an Idea I'm open to suggestions.
While testing this I noticed that while creating/renaming a bot the username is updated in the UI only after reloading. I'm not quite shure as to where I'd have to fix this and would like some guidance so that I can fix that there so that the UX is consistent for normal and bot users.
Please make sure to check the following tasks before opening and submitting a PR